[wayland] Recursively destroy WindowPixmap objects
ClosedPublic
Actions

Authored by zzag on Mar 19 2020, 5:49 PM.

Details

Reviewers

davidedmundson

Group Reviewers

KWin

Commits

Summary

We need to destroy the root WindowPixmap together with all of its
children; otherwise, buffers that are attached to subsurfaces will
not be released.

Test Plan

weston-subsurfaces doesn't quit with an error message saying that
all buffers are held by the compositor.

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a project: KWin. · View Herald TranscriptMar 19 2020, 5:49 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.Mar 19 2020, 5:49 PM

This patch doesn't fix frozen firefox windows.

This revision is now accepted and ready to land.Mar 19 2020, 5:55 PM

@davidedmundson Would it be okay if I push this patch to Plasma/5.18? My original intent was to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1593478

Sure.

This revision was automatically updated to reflect the committed changes.

baberts added a subscriber: baberts.

			Path	Packages
M			scene.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	78034	c0c693e		Mar 19 2020, 5:49 PM	★	★
Diff 2	78045	348e72c	R108:25276d30583c2b5d5c15aba077511458011d91d4	Mar 19 2020, 8:41 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
2e717f7a1ad7	8b721c73fc02	c0c693efb313	Vlad Zahorodnii	[wayland] Recursively destroy WindowPixmap objects (Show More…)	Mar 19 2020, 5:25 PM