Add "veryLongDuration" animation duration
ClosedPublic

Authored by ngraham on Mar 19 2020, 5:22 PM.

Details

Summary

As discussed in D28033#630649.

Test Plan

Compiles. Not used anywhere yet, so no testing possible.

Diff Detail

Repository
R169 Kirigami
Branch
veryLongDuration (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23955
Build 23973: arc lint + arc unit
ngraham created this revision.Mar 19 2020, 5:22 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptMar 19 2020, 5:22 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Mar 19 2020, 5:22 PM
ngraham updated this revision to Diff 78037.Mar 19 2020, 6:29 PM

Forgot one thing

mart added a comment.Mar 20 2020, 3:03 PM

a problem tough.. this one won't follow system settngs, so globally disabling anoimations won't disable this one
it also needs implementing in plasma-framework/src/declarativeimports/kirigamiplasmadesktopstyle/ (where takes values from units.cpp in plasma units, which should get a very long duration as well.. those do follow global system durations, so would solve the problem)

mart requested changes to this revision.Mar 20 2020, 3:03 PM
This revision now requires changes to proceed.Mar 20 2020, 3:03 PM
davidre added a subscriber: davidre.EditedMar 20 2020, 3:04 PM
In D28143#631225, @mart wrote:

a problem tough.. this one won't follow system settngs, so globally disabling anoimations won't disable this one
it also needs implementing in plasma-framework/src/declarativeimports/kirigamiplasmadesktopstyle/ (where takes values from units.cpp in plasma units, which should get a very long duration as well.. those do follow global system durations, so would solve the problem)

See D28144

mart accepted this revision.Mar 20 2020, 3:38 PM

sorry, didn't see the other one

This revision is now accepted and ready to land.Mar 20 2020, 3:38 PM
This revision was automatically updated to reflect the committed changes.