Differential D28138

some static analyzer improvements for service runner
ClosedPublic
Actions

Authored by sitter on Mar 19 2020, 2:13 PM.

Details

Reviewers
broulik
Commits
R120:fab5b5e26d7e: some static analyzer improvements for service runner
Summary
  • be more consty (and don't risk detatching containers)
  • init members
  • don't ql1s to qstring
  • use auto when newing an object
Test Plan

test passes

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23929
Build 23947: arc lint + arc unit
sitter created this revision.Mar 19 2020, 2:13 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 19 2020, 2:13 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Mar 19 2020, 2:13 PM
broulik accepted this revision.Mar 19 2020, 2:18 PM
broulik added inline comments.
runners/services/servicerunner.cpp
114

Perhaps use .at(i)

464

Keep the * :p

This revision is now accepted and ready to land.Mar 19 2020, 2:18 PM
Closed by commit R120:fab5b5e26d7e: some static analyzer improvements for service runner (authored by sitter). · Explain WhyMar 19 2020, 2:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 78001

View Options

runners/services/autotests/servicerunnertest.cpp

Loading...
View Options

runners/services/servicerunner.h

Loading...
View Options

runners/services/servicerunner.cpp

Loading...