make servicerunner only build once
ClosedPublic
Actions

Authored by sitter on Mar 19 2020, 1:52 PM.

Details

Reviewers

broulik
davidedmundson

Commits

R120:d03f98e782c3: make servicerunner only build once

Summary

build the runner itself in a static lib we can use for testing and then
link that into a module lib together with the factory entry point to
compose the final lib for installation

means servicesrunner.cpp is now only built once, whereas before it was
built twice through 100% duplicative targets

Test Plan

test still passes, installing and restarting krunner still yields working service searches

Diff Detail

Repository

R120 Plasma Workspace

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 23928
Build 23946: arc lint + arc unit

sitter created this revision.Mar 19 2020, 1:52 PM

Restricted Application added a project: Plasma. · View Herald TranscriptMar 19 2020, 1:52 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

sitter requested review of this revision.Mar 19 2020, 1:52 PM

Harbormaster completed remote builds in B23928: Diff 77999.Mar 19 2020, 1:52 PM

davidedmundson accepted this revision.Mar 19 2020, 6:00 PM

This revision is now accepted and ready to land.Mar 19 2020, 6:00 PM

Closed by commit R120:d03f98e782c3: make servicerunner only build once (authored by sitter). · Explain WhyMar 20 2020, 10:02 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		runners/services/CMakeLists.txt (18 lines)
M		runners/services/autotests/CMakeLists.txt (2 lines)
A	M	runners/services/plugin.cpp (25 lines)
M		runners/services/servicerunner.cpp (4 lines)