[applets/digital-clock] Switch timezones by clicking on them in the popup
ClosedPublic

Authored by ngraham on Mar 19 2020, 4:16 AM.

Details

Summary

This patch allows you to switch the timezone by clicking on your desired one in the
applet's expanded representation. This is much simpler than the mouse-wheel-based UI and
does not need a config setting to turn it on or off.

Test Plan

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Mar 19 2020, 4:16 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 19 2020, 4:16 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Mar 19 2020, 4:16 AM
cblack accepted this revision.Mar 23 2020, 8:38 PM
This revision is now accepted and ready to land.Mar 23 2020, 8:38 PM
This revision was automatically updated to reflect the committed changes.

Be careful about mixing terms here.

This absolutely does not change "the timezone". This changes what the applet shows. It is super super important that if a user travels to another country even for a vacation they update the system timezone.

The reason this had a configuration option was because we need people to not use the wrong thing. The applet's timezone purpose is so you can show a clock of what time it is for your European colleagues or whatever.

Hmm, that's a good point. I hadn't realized that. Would it make sense for changing the timezone in the applet to actually change the whole system timezone too, rather than just the display in the applet? Is that something we can do?