Differential D28132

[Calculator Runner] Minor code optimisation
ClosedPublic
Actions

Authored by ahmadsamir on Mar 18 2020, 5:30 PM.

Details

Reviewers
apol
davidedmundson
Group Reviewers
Plasma
Commits
R120:cd37cc6926c3: [Calculator Runner] Minor code optimisation
Summary

Remove redunant QString::contains() checks.

Create one QRegularExpression object and use setPattern().

Test Plan

make && ctest

Diff Detail

Repository
R120 Plasma Workspace
Branch
l-calcrun (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23892
Build 23910: arc lint + arc unit
ahmadsamir created this revision.Mar 18 2020, 5:30 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 18 2020, 5:30 PM
ahmadsamir requested review of this revision.Mar 18 2020, 5:30 PM
davidedmundson accepted this revision.Mar 18 2020, 6:38 PM
This revision is now accepted and ready to land.Mar 18 2020, 6:38 PM
Closed by commit R120:cd37cc6926c3: [Calculator Runner] Minor code optimisation (authored by ahmadsamir). · Explain WhyMar 18 2020, 6:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 77945

View Options

runners/calculator/calculatorrunner.cpp

Loading...