Readability. Simplify overly complex code
ClosedPublic
Actions

Authored by apol on Sep 19 2016, 1:08 PM.

Details

Reviewers

Group Reviewers

Commits

Summary

We have a big case because the size depend on whether the panel is vertical or horizontal
but it doesn't really bring much.

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

apol retitled this revision from to Readability. Simplify overly complex code.

apol updated this object.

apol edited the test plan for this revision. (Show Details)

apol added a reviewer: Plasma.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

This revision is now accepted and ready to land.Sep 19 2016, 1:12 PM

This revision was automatically updated to reflect the committed changes.

the change itself is actually ok, but can we avoid further changes that aren't an explicit bugfix in 5.8 branch prior the release?

			Path	Packages
M			shell/panelview.cpp (38 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	6815	0d4802d		Sep 19 2016, 1:08 PM	★	★
Diff 2	6816	3bf1372	rPLASMAWORKSPACE89c34a853b64865189ad262273dcf050448c105f	Sep 19 2016, 1:22 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
0bb3ce3b7a1d	7048f594e3ef	0d4802db1e6a	Aleix Pol	Readability. Simplify overly complex code (Show More…)	Sep 19 2016, 1:08 PM