Application menu information is now available via KWindowInfo's APIs on X11.
Details
Details
- Reviewers
broulik zzag - Group Reviewers
Plasma KWin - Commits
- R278:93814b513d45: Expose application menu via KWindowInfo
Diff Detail
Diff Detail
- Repository
- R278 KWindowSystem
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| autotests/netwininfotestclient.cpp | ||
|---|---|---|
| 281–319 | You have to change properties via xcb_change_property(). void NetWinInfoTestClient::testAppMenuObjectPath() { ATOM(_KDE_NET_WM_APPMENU_OBJECT_PATH) INFO QVERIFY(!info.appMenuObjectPath()); xcb_change_property(connection(), XCB_PROP_MODE_REPLACE, m_testWindow, atom, XCB_ATOM_STRING, 8, 4, "foo\0"); xcb_flush(connection()); waitForPropertyChange(&info, atom, NET::Property(0), NET::WM2AppMenuObjectPath); QCOMPARE(info.appMenuObjectPath(), "foo"); } void NetWinInfoTestClient::testAppMenuServiceName() { ATOM(_KDE_NET_WM_APPMENU_SERVICE_NAME) INFO QVERIFY(!info.appMenuServiceName()); xcb_change_property(connection(), XCB_PROP_MODE_REPLACE, m_testWindow, atom, XCB_ATOM_STRING, 8, 4, "foo\0"); xcb_flush(connection()); waitForPropertyChange(&info, atom, NET::Property(0), NET::WM2AppMenuServiceName); QCOMPARE(info.appMenuServiceName(), "foo"); } | |
| src/netwm_def.h | ||
| 727–728 | Missing // NOT STANDARD @since | |
| src/platforms/xcb/netwm.cpp | ||
| 3536 | s/p->atom(UTF8_STRING)/XCB_ATOM_STRING/ | |
| 3550 | s/p->atom(UTF8_STRING)/XCB_ATOM_STRING/ | |
| 4681 | s/p->atom(UTF8_STRING)/XCB_ATOM_STRING/ | |
| 4691 | s/p->atom(UTF8_STRING)/XCB_ATOM_STRING/ | |
| autotests/netwininfotestclient.cpp | ||
|---|---|---|
| 281–319 | please get rid of '\0' | |
| src/platforms/xcb/netwm.cpp | ||
|---|---|---|
| 4677–4707 | Please move WM2GTKFrameExtents above WM2AppMenuObjectPath to match the order in which cookies is filled. | |