This change simplifies icon size logic - now it is controled only in one place: AbstractItem. This gives additional benefits, like icons perfectly centered.
Details
Details
- Reviewers
ngraham broulik davidedmundson apol - Group Reviewers
Plasma: Workspaces Plasma - Commits
- R120:a9d941b38e05: [applets/systemtray] Simplify icon size logic
- Highlights should always be centered
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 23842 Build 23860: arc lint + arc unit
| applets/systemtray/package/contents/ui/ExpanderArrow.qml | ||
|---|---|---|
| 31 | This fixes issue (regression) with expander arrow not hiding when all items are visible. Probably I should create separate commit... | |
| applets/systemtray/package/contents/ui/items/ItemLoader.qml | ||
| 28 | The effectiveStatus was copied from the model, not binded. Separate commit? | |
Comment Actions
This looks like a sensible refactor to me, and it solves the issue that I was having with icon size changing based on the expanded popup visibility. I can't detect any regressions in sizing with horizontal or vertical panels of various sizes. However please wait to land this until somebody else possessing greater familiarity with this codebase such as @broulik, @mart, or @davidedmundson reviews it too.
Comment Actions
Depends on the view; most people don't seem to use Phab's homepage so much compared to the email notifications generated when you mention people like @broulik, @mart, or @davidedmundson ;)