Show command output on unknown failure
ClosedPublic

Authored by ivan on Mar 17 2020, 1:14 PM.

Details

Summary

If the error is unknown (all errors in encfs), show the 'details...' button
which shows the command line output to the user when activated.

BUG:412779

Diff Detail

Repository
R845 Plasma Vault
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23813
Build 23831: arc lint + arc unit
ivan created this revision.Mar 17 2020, 1:14 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 17 2020, 1:14 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ivan requested review of this revision.Mar 17 2020, 1:14 PM
davidedmundson added inline comments.Mar 17 2020, 2:09 PM
kded/ui/mountdialog.cpp
57

Kded is one of the processes that shouldn't freeze, lets avoid nested event loops

Some sort of

box = new QMessageBox()
box->setWidgetAttribute(delete on close)
box->show();

would be preferred

ivan added a comment.Mar 17 2020, 2:32 PM

Of course... I need to reboot my brain it seems.

ivan updated this revision to Diff 77828.Mar 17 2020, 2:36 PM
ivan marked an inline comment as done.
davidedmundson accepted this revision.Mar 17 2020, 3:11 PM
This revision is now accepted and ready to land.Mar 17 2020, 3:11 PM
This revision was automatically updated to reflect the committed changes.