Differential D28094

[breeze-icons] fix shadow in some user (applets/128) icons
ClosedPublic
Actions

Authored by rocka on Mar 17 2020, 10:08 AM.

Details

Reviewers

ndavis

Group Reviewers

VDG

Commits

R266:f4a6bf060b0c: [breeze-icons] fix shadow in some user (applets/128) icons

Summary

When executing kdialog --geticon, some errors would shown:

$ kdialog --geticon
qt.svg: /usr/share/icons/breeze-dark/applets/128/user-ada-lovelace.svg:68: Could not resolve property: #linearGradient6624
qt.svg: /usr/share/icons/breeze-dark/applets/128/user-ada-lovelace.svg:68: Could not resolve property: #linearGradient6626
qt.svg: /usr/share/icons/breeze-dark/applets/128/user-leonardo-da-vinci.svg:79: Could not resolve property: #linearGradient6634

... And those 2 icons don't have correct shadow. This patch fixes it.

Test Plan

Before

After

Diff Detail

Repository

R266 Breeze Icons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

rocka created this revision.Mar 17 2020, 10:08 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptMar 17 2020, 10:08 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

rocka requested review of this revision.Mar 17 2020, 10:08 AM

Harbormaster completed remote builds in B23804: Diff 77811.Mar 17 2020, 10:08 AM

rocka edited the test plan for this revision. (Show Details)Mar 17 2020, 10:09 AM

rocka added a reviewer: VDG.

rocka edited the summary of this revision. (Show Details)

remove svg metadata

Harbormaster completed remote builds in B23806: Diff 77814.Mar 17 2020, 10:17 AM

I'm not sure if we actually use these anywhere, but the patch looks good to me.

This revision is now accepted and ready to land.Mar 17 2020, 5:39 PM

Hmm. The shadows no longer work correctly in Inkscape, but they work fine in the Qt SVG renderer, which is unusual since usually the Qt SVG renderer is the picky one.

Can you fix the files for inkscape?

This revision now requires changes to proceed.Mar 17 2020, 5:46 PM

Weird, I edited them in Inkscape …

Aren't those icons used as default avatar in user manager?

In D28094#629427, @rocka wrote:

Weird, I edited them in Inkscape …

Aren't those icons used as default avatar in user manager?

Nope. Those were actually kept in the user-manager repo until they were removed in June 2019. These don't seem to be used for anything at all.

BTW, you can use this website to search for text in the code of all KDE software: https://lxr.kde.org/search

Try to fix icon display in inkscape

Harbormaster completed remote builds in B23854: Diff 77886.Mar 18 2020, 9:21 AM

lgtm

This revision is now accepted and ready to land.Mar 18 2020, 11:56 AM

Closed by commit R266:f4a6bf060b0c: [breeze-icons] fix shadow in some user (applets/128) icons (authored by rocka, committed by ndavis). · Explain WhyMar 18 2020, 11:57 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			icons-dark/applets/128/user-ada-lovelace.svg (116 lines)
M			icons-dark/applets/128/user-leonardo-da-vinci.svg (82 lines)
M			icons/applets/128/user-ada-lovelace.svg (116 lines)
M			icons/applets/128/user-leonardo-da-vinci.svg (82 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	77811	5cb7992		Mar 17 2020, 10:08 AM	★	★
Diff 2	77814	5cb7992	remove svg metadata	Mar 17 2020, 10:17 AM	★	★
Diff 3	77886	0855a40	Try to fix icon display in inkscape	Mar 18 2020, 9:21 AM	★	★
Diff 4	77902	3e095e8	R266:f4a6bf060b0caedd0a16a9bbbec7ef3103e00560	Mar 18 2020, 11:57 AM	★	★