Fix for context menu "Open with"->"Other..." option opens only first selected file.
ClosedPublic
Actions

Authored by abika on Sep 17 2016, 9:06 PM.

Details

Reviewers

None

Group Reviewers

Krusader

Commits

Summary

Fixes Bug 297079

Repository

R167 Krusader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

abika retitled this revision from to Fix for context menu "Open with"->"Other..." option opens only first selected file..

abika updated this object.

abika edited the test plan for this revision. (Show Details)

abika added a reviewer: Krusader.

This revision was automatically updated to reflect the committed changes.

You can't pass a QList of urls to every program, not every program likes it so no files are opened at all.

It is the program task to take the urls passed by KIO, but Krusader cannot know it.

We can change ListPanelFunc::displayOpenWithDialog in the same way of KrPopupMenu::performAction case OPEN_ID

The problem is the DesktopExecParser used in ListPanelFunc::runService(). Depending on the application it simply removes all arguments.

			Path	Packages
M			krusader/Panel/krpopupmenu.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	6797	834a760		Sep 17 2016, 9:06 PM	★	★
Diff 2	6798	834a760	rKRUSADER639f6c16a281b6023554e6a7f4229f8be9c76bdf	Sep 17 2016, 9:01 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
639f6c16a281	ad6f52b10adf	834a7608bae6	Alexander Bikadorov	Fix for context menu "Open with"->"Other..." option opens only first selected… (Show More…)	Sep 17 2016, 9:01 PM