guard against duplicated service discoveries
ClosedPublic

Authored by sitter on Mar 16 2020, 2:43 PM.

Details

Summary

if both dnssd and wsdiscovery have the same server on offer we'd create
duplicated entries. instead keep track of the discovered names and only
use the first discovery. notably happens when using wsdd on linux where
samba would also register itself on dnssd.

for ease of access and to not have to roundtrip through udsentry, discovery
objects now have a udsName function that is meant to be the exact name
used for the udsentry.

Test Plan

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Mar 16 2020, 2:43 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptMar 16 2020, 2:43 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Mar 16 2020, 2:43 PM

FTR: this could technically still dupe with smbc native NT1 listing, except smbc would list workgroups while we list services, so this should generally not be duplicative information.

ngraham accepted this revision.Mar 16 2020, 4:06 PM

Yeah.

This revision is now accepted and ready to land.Mar 16 2020, 4:06 PM
This revision was automatically updated to reflect the committed changes.