Differential D28065

Add missing types to qrc
ClosedPublic
Actions

Authored by nicolasfella on Mar 16 2020, 12:04 AM.

Details

Reviewers
apol
Commits
R169:f1ac443fefff: Add missing types to qrc

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Mar 16 2020, 12:04 AM
Restricted Application added a project: Kirigami. · View Herald TranscriptMar 16 2020, 12:04 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Mar 16 2020, 12:04 AM
apol accepted this revision.Mar 16 2020, 12:11 AM
This revision is now accepted and ready to land.Mar 16 2020, 12:11 AM
keithzg added a subscriber: keithzg.Mar 16 2020, 5:25 AM

Can confirm this solves my crash when trying to run on Android, which previous killed my app on startup if trying to use a CardsListView:

LOGCAT: W quickgear: QQmlApplicationEngine failed to load component
LOGCAT: W quickgear: qrc:/qml/main.qml:17:28: Type ShowsPage unavailable
LOGCAT: W quickgear: qrc:/qml/ShowsPage.qml:30:2: Type Kirigami.CardsListView unavailable
LOGCAT: W quickgear: qrc:/org/kde/kirigami/CardsListView.qml:27:1: CardsListViewPrivate is not a type

Now it's all good :)

Closed by commit R169:f1ac443fefff: Add missing types to qrc (authored by nicolasfella). · Explain WhyMar 16 2020, 9:41 AM
This revision was automatically updated to reflect the committed changes.
broulik added a subscriber: broulik.Mar 16 2020, 9:47 AM

I was wondering, could this file be auto-generated by cmake?

Revision Contents
Changeset List

PathPackages
Mkirigami.qrc (2 lines)
Mkirigami.qrc.in (2 lines)

Diff 77707

View Options

kirigami.qrc

Loading...
View Options

kirigami.qrc.in

Loading...