[applet/notes] Show a "remove" button on the button row

Authored by ngraham on Mar 15 2020, 10:36 PM.



I've personally observed various users struggle to remove a Sticky Note widget, and heard
anedcotal user reports about this too. Some people look for a close button and don't
find one, never thinking to press-and-hold or right-click. Some people do right-click
but right-click in the content area rather than the frame (which look identical), and see
the context menu for the text rather than the widget itself.

This patch alleviates this user confusion by adding a Remove button on the button
row on the bottom of the widget, next to the Configure... button. This makes it
very easy to remove a Sticky Note. This is not destructive because there's an undo, so
it's not a big deal if someone clicks the button by mistake.

It could be argued that this makes the applet inconsistent with other widgets which do
not display visible Remove buttons, which is true. However the nature of the Sticky
Note applet is that it is likely to be used in a more transient or temporary manner than
other widgets; it often has more in common with a temporary document than a permanent
fixture of your desktop. For this reason, I believe it is appropriate to show a visible
Remove button on the widget.

The default size of the widget is increased a bit so that there's room for the new
remove button as well as the text control buttons.

Test Plan

Diff Detail

R114 Plasma Addons
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Mar 15 2020, 10:36 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 15 2020, 10:36 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Mar 15 2020, 10:36 PM
ngraham edited the summary of this revision. (Show Details)Mar 15 2020, 10:40 PM
ndavis accepted this revision.Mar 15 2020, 10:50 PM
ndavis added a subscriber: ndavis.

makes sense to me

This revision is now accepted and ready to land.Mar 15 2020, 10:50 PM
This revision was automatically updated to reflect the committed changes.