No need to keep them around for no reason.
According to Qt documentation, we should interpret QVariant::Type as QMetaType::Type.
Do compilers bark about using c-style casts?
Indentation is off.
Unrelated side note: this is really wrong!
Unrelated side note: I don't get why Qt folks deprecated toSet(). Range-based initialization looks very clunky if you ask me.
The warning is:
Could you please revert this change? The documentation says that we should use QMetaType.
I assume the compiler doesn't like conversions between QVariant::Type and QMetaType::Type. If that's the case, we could cast the return value of value.type() or use value.userType() as Qt folks do.
void start(const QString &command, OpenMode mode = ReadWrite); is deprecated.
We could also use