Fix on wayland activating minimized window will move window to current desktop
Needs ReviewPublic

Authored by pereira.alex on Sun, Mar 15, 1:43 PM.

Details

Reviewers
zzag
Group Reviewers
Plasma
Summary

As reported on bug #417888, on wayland if a window is minimized
on VD1 and clicked to activate on VD2, it will put window
to VD1 and VD2.
By not calling the activate on minimized windows, it will fix this behaviour.
( I think this only happens on wayland because only on wayland you can put windows
on VD1 and VD2 but not VDX, meaning not on all desktops )

I tested this on X11 and Wayland, and everything seems to be working correctly.

Diff Detail

Repository
R119 Plasma Desktop
Branch
fix-taskmanager-minimized-windows-virtual-desktops-bug (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23713
Build 23731: arc lint + arc unit
pereira.alex created this revision.Sun, Mar 15, 1:43 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSun, Mar 15, 1:43 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
pereira.alex requested review of this revision.Sun, Mar 15, 1:43 PM
ngraham added a subscriber: ngraham.

Thanks for the patch! In general, don't comment out code, just remove the lines instead. Also if this fixes, 417888, add BUG: 417888 on its own line somewhere in the description section of this patch.

zzag added a comment.EditedMon, Mar 16, 8:42 PM

it will put window to VD1 and VD2.

It seems to me like this bug must be fixed in KWin rather than the task manager.

pereira.alex added a comment.EditedMon, Mar 16, 11:22 PM
In D28055#628705, @zzag wrote:

it will put window to VD1 and VD2.

It seems to me like this bug must be fixed in KWin rather than the task manager.

In what I understand, wayland allows to specify in with virtual desktops windows can be, in contrast with x11, which a windows is on one virtual desktop or all of them. Is this correct ?

@zzag how should I proceed ? I don't know much about KWin source code, but if I may be of help, this could be a good way to start !

zzag added a comment.Tue, Mar 17, 7:50 AM

Yes, on Wayland, a window can be more on than just one desktop. However, in this scenario, the minimized window should not be placed on other desktops.

how should I proceed ?

First, we need to make sure that plasmashell doesn't put the window on other desktops. We could do that by running WAYLAND_DEBUG=1 plasmashell and then analyzing the output. If plasmashell indeed doesn't place the window on other desktops, put some qDebugs in KWin to see where things go wrong.