Made window backgroun color lighter

Authored by niccolove on Mar 15 2020, 1:19 PM.


Group Reviewers

This is a patch to discuss (not to be landed yet) the possibility of making the window color lighter. I feel like a lighter color would be better suited, especially as soon as D27669 lands. I tried to select a gray shade that still is visually different to the views background color. See screenshots:



With the patch (nb, simulated with kvantum by making the window inactive - in this screenshot, it's a even lighter than what it will actually be with this patch):

Diff Detail

R31 Breeze
lighter_windowbackground (branched from master)
No Linters Available
No Unit Test Coverage
Build Status
Buildable 23712
Build 23730: arc lint + arc unit
niccolove created this revision.Mar 15 2020, 1:19 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 15 2020, 1:19 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
niccolove requested review of this revision.Mar 15 2020, 1:19 PM
niccolove edited the summary of this revision. (Show Details)Mar 15 2020, 1:21 PM
niccolove added a reviewer: VDG.
cblack retitled this revision from Made window backgroun color lighter to RFC: Make window background color lighter.Mar 15 2020, 1:22 PM
niccolove retitled this revision from RFC: Make window background color lighter to Made window backgroun color lighter.Mar 15 2020, 1:22 PM
niccolove edited the summary of this revision. (Show Details)
filipf added a subscriber: filipf.Mar 15 2020, 1:34 PM

I already prepared this sort of a patch while ago because I believe the Breeze color schemes should have more contrast in order to look more modern.

I chose 243, 244, 245 as the new color though since I still wanted to keep it different from the view color.

This (249, 249, 249) looks fine but I'd suggest to tone the new color down just a little bit to avoid complaints.

I'd also suggest to see where else the old color is used and replace it. This means more changes in this particular file and then all over KDE.

TBH, I don't really like it. I would be okay with lightening the window BG color a little bit, in preparation for the Tools Area being visibly darker, but I think this takes it a too far. The difference is super muted in the screenshots you show where there's a line separating the two colors, and it becomes even more subtle where there is no such line, for example in the alternating stripey backgrounds in Dolphin's details view. The contrast is just not enough IMO.

It feels like your actual goal is to get rid of the visual distinction between the window BG and view BG entirely, and use the same color for both. If that's the case, than a half-measure patch like this will actually please nobody: people who like the current contrast between those colors will be irritated, while the people who want there to be no difference at all won't get what they want either.

We need to revisit the default colorschemes for the Tools Area change anyway, but I think we should do it in a coordinated manner that takes into account that change.

And yeah, as @flipwise points out, once we change the color schemes, there are various other places throughout KDE where it needs to be changed as well.

ngraham requested changes to this revision.Mar 16 2020, 4:07 PM
This revision now requires changes to proceed.Mar 16 2020, 4:07 PM