Make the animation slider more granular
ClosedPublic

Authored by pereira.alex on Sun, Mar 15, 11:47 AM.

Details

Summary

Between default animation speed and slower/faster, there is a huge change.
Making the slider change from 0.5 instead of one,
makes the speed of animation change in much smaller changes

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
pereira.alex created this revision.Sun, Mar 15, 11:47 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSun, Mar 15, 11:47 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
pereira.alex requested review of this revision.Sun, Mar 15, 11:47 AM

More info: as discussed here: https://www.reddit.com/r/kde/comments/fgwcou/tip_animation_speedslider/

Also, please, be gentle, this is the first time doing tasks on phabricator and using arcanist. If i am doing something wrong, please ELI5

Trying to add the correct reviewers :)

ngraham accepted this revision.Mon, Mar 16, 8:30 PM
ngraham added subscribers: davidedmundson, ngraham.

Seems reasonable to me. I agree that the current steps are not quite granular enough for people who just want to tweak the default settings a little bit.

@davidedmundson, thoughts?

This revision is now accepted and ready to land.Mon, Mar 16, 8:30 PM
ngraham retitled this revision from Making the Animation Slider more granular to Make the animation slider more granular.Mon, Mar 16, 8:30 PM
davidedmundson accepted this revision.Mon, Mar 16, 9:49 PM

Change is fine, we deliberately store the value as the raw float to allow any UI separation.

Thanks for your first patch. You did everything right. Good stuff.

broulik accepted this revision.Mon, Mar 16, 11:34 PM
broulik added a subscriber: broulik.

Yeah go for it

thank you all for the positive feedback :)

I am not a kde dev ( don't have a developer account ). I will try to apply for one, but in the meanwhile, anyone could land this?

This revision was automatically updated to reflect the committed changes.