Add an ultimate fallback to WM_CLASS Class for AbstractTasksModel::AppId in XWindowsTasksModel.
ClosedPublic

Authored by hein on Sep 17 2016, 1:57 PM.

Details

Summary

This makes grouping work for apps we can't find on the system and
can't produce a launcher URL for, such as wine clients. Any better
app will use our superior codepath, the wonky ones like wine then
get left to making sure their WM_CLASS Class makes sense as per the
ICCCM spec.

Of course this doesn't work for XWayland clients on Wayland though.

BUG:368078

Also nixes an obsolete FIXME and adds a small check to avoid
producing launcher URLs that are only the window icon pixmap
query element.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hein updated this revision to Diff 6791.Sep 17 2016, 1:57 PM
hein retitled this revision from to Add an ultimate fallback to WM_CLASS Class for AbstractTasksModel::AppId in XWindowsTasksModel..
hein updated this object.
hein edited the test plan for this revision. (Show Details)
hein added reviewers: Plasma, davidedmundson, broulik.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 17 2016, 1:57 PM
davidedmundson accepted this revision.Sep 18 2016, 3:20 PM
davidedmundson edited edge metadata.
This revision is now accepted and ready to land.Sep 18 2016, 3:20 PM
This revision was automatically updated to reflect the committed changes.