[Applet] Port to ExpandableListItem
ClosedPublic

Authored by ngraham on Mar 13 2020, 5:27 PM.

Details

Summary

Depends on D28033

Test Plan

All functionality still works. There are minimal visual changes, mostly little things
to make the appearance consistent with other applets using the new ExpandableListItem
component.

Diff Detail

Repository
R845 Plasma Vault
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Mar 13 2020, 5:27 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 13 2020, 5:27 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Mar 13 2020, 5:27 PM
ivan added a comment.Mar 15 2020, 12:22 AM

I like it. Is the device notifier going to look like this as Vaaults tried to mimic that one?

Yes, that's the last one I need to port. I've already submitted patches to port the Printers, Bluetooth, and Networks applets, as they also have the same style.

ivan accepted this revision.Mar 15 2020, 7:25 AM

I assume people tell you that you're awesome all the time, so I'm not going to ;)

This revision is now accepted and ready to land.Mar 15 2020, 7:25 AM
ngraham updated this revision to Diff 77699.Mar 16 2020, 3:24 AM

Use consistent highlight animation durations

ngraham updated this revision to Diff 77937.Mar 18 2020, 4:21 PM

ExpandableListItem is now in PlasmaExtras

ngraham updated this revision to Diff 77966.Mar 18 2020, 11:22 PM

Remove now-unnecessary imports

ngraham updated this revision to Diff 79437.Apr 5 2020, 10:54 PM

Update required Frameworks version

This revision was automatically updated to reflect the committed changes.