Differential D28031

scene: Pass non-trivial classes by const&
ClosedPublic
Actions

Authored by apol on Mar 13 2020, 4:42 PM.

Details

Reviewers

davidedmundson

Group Reviewers

KWin

Commits

R108:e8efa8344407: scene: Pass non-trivial classes by const&

Summary

This will save the copy of some objects, especially PaintData classes that are
not copy-on-write.
It also follows the practice on other parts of the system.

Test Plan

Running it right now

Diff Detail

Repository

R108 KWin

Branch

master

Lint

Lint Errors

Excuse: xxx

Severity	Location	Code	Message
Error	input.h:310	Cppcheck	unknownMacro
Error	input.h:310	Cppcheck	unknownMacro

Unit

No Unit Test Coverage

Build Status

Buildable 23670
Build 23688: arc lint + arc unit

apol created this revision.Mar 13 2020, 4:42 PM

Restricted Application added a project: KWin. · View Herald TranscriptMar 13 2020, 4:42 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

apol requested review of this revision.Mar 13 2020, 4:42 PM

Harbormaster completed remote builds in B23670: Diff 77579.Mar 13 2020, 4:42 PM

davidedmundson accepted this revision.Mar 13 2020, 4:51 PM

This revision is now accepted and ready to land.Mar 13 2020, 4:51 PM

Closed by commit R108:e8efa8344407: scene: Pass non-trivial classes by const& (authored by apol). · Explain WhyMar 14 2020, 12:15 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			plugins/scenes/opengl/scene_opengl.h (16 lines)
M			plugins/scenes/opengl/scene_opengl.cpp (20 lines)
M			plugins/scenes/qpainter/scene_qpainter.h (10 lines)
M			plugins/scenes/qpainter/scene_qpainter.cpp (12 lines)
M			plugins/scenes/xrender/scene_xrender.h (10 lines)
M			plugins/scenes/xrender/scene_xrender.cpp (11 lines)
M			scene.h (24 lines)
M			scene.cpp (19 lines)