Differential D28029

Use `ShadowedRectangle`
ClosedPublic
Actions

Authored by broulik on Mar 13 2020, 3:51 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R858:1bb57b10e7bd: Use `ShadowedRectangle`
Summary

Instead of expensive DropShadow layer.

Test Plan
  • Looks the same as before

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Mar 13 2020, 3:51 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 13 2020, 3:51 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mar 13 2020, 3:51 PM
ngraham requested changes to this revision.Mar 13 2020, 5:57 PM
ngraham added a subscriber: ngraham.

there's no version 2.12 for Kirigami, that's a QQC version

This revision now requires changes to proceed.Mar 13 2020, 5:57 PM
broulik added a comment.Mar 16 2020, 10:32 AM

kirigamiplugin.cpp:

// 2.12
qmlRegisterType<ShadowedRectangle>(uri, 2, 12, "ShadowedRectangle");
broulik retitled this revision from WIP: Use `ShadowedRectangle` to Use `ShadowedRectangle`.Mar 16 2020, 10:32 AM
broulik edited the test plan for this revision. (Show Details)
ngraham accepted this revision.Mar 16 2020, 2:42 PM

My bad, sorry. LGTM.

This revision is now accepted and ready to land.Mar 16 2020, 2:42 PM
Closed by commit R858:1bb57b10e7bd: Use `ShadowedRectangle` (authored by broulik). · Explain WhyMar 16 2020, 2:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 77573

View Options

org.kde.desktop/ComboBox.qml

Loading...
View Options

org.kde.desktop/Menu.qml

Loading...
View Options

org.kde.desktop/Popup.qml

Loading...
View Options

org.kde.desktop/ToolTip.qml

Loading...