Differential D28018

kcmkwin/scripts: fix a warning
ClosedPublic
Actions

Authored by meven on Mar 13 2020, 9:32 AM.

Details

Reviewers
ervin
bport
cross
hchain
zzag
Group Reviewers
KWin
Commits
R108:40ebb4e245ef: kcmkwin/scripts: fix a warning
Summary

Prevents warnings such as :
org.kde.kcoreaddons: Expected JSON property "X-KWin-Exclude-Listing" to be a single string. but it is a bool

Diff Detail

Repository
R108 KWin
Branch
arcpatch-D28018
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 23647
Build 23665: arc lint + arc unit
meven created this revision.Mar 13 2020, 9:32 AM
Restricted Application added a project: KWin. · View Herald TranscriptMar 13 2020, 9:32 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
meven requested review of this revision.Mar 13 2020, 9:32 AM
zzag added a subscriber: zzag.Mar 13 2020, 9:37 AM
zzag added inline comments.
kcmkwin/kwinscripts/module.cpp
128–129

Can be simplified to

return !md.rawData().value("X-KWin-Exclude-Listing").toBool();
meven updated this revision to Diff 77543.Mar 13 2020, 9:42 AM
meven marked an inline comment as done.

Simplify

zzag accepted this revision.Mar 13 2020, 9:46 AM

KCM/kwinscripts:

Please change it to [kcmkwin/kwinscripts] or [kcmkwin/scripts]

This revision is now accepted and ready to land.Mar 13 2020, 9:46 AM
meven retitled this revision from KCM/kwinscripts: fix a warning to kcmkwin/scripts: fix a warning.Mar 13 2020, 9:48 AM
Closed by commit R108:40ebb4e245ef: kcmkwin/scripts: fix a warning (authored by meven). · Explain WhyMar 13 2020, 9:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcmkwin/kwinscripts/module.cpp (5 lines)

Diff 77543

View Options

kcmkwin/kwinscripts/module.cpp

Loading...