Differential D28014

smb: do not double finish
ClosedPublic
Actions

Authored by sitter on Mar 12 2020, 1:07 PM.

Details

Reviewers
ngraham
Commits
R320:8252861157a2: smb: do not double finish
Summary

finish() must not be called twice yet previously the case branches
would call it but then there'd also be a global finished after the switch.
remove the cases' finished().

this code is, I think, actually not used anywhere so it matters little.

Test Plan

hoping for the best!

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Mar 12 2020, 1:07 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptMar 12 2020, 1:07 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Mar 12 2020, 1:07 PM
ngraham accepted this revision.Mar 13 2020, 6:53 PM
This revision is now accepted and ready to land.Mar 13 2020, 6:53 PM
Closed by commit R320:8252861157a2: smb: do not double finish (authored by sitter). · Explain WhyMar 16 2020, 11:02 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msmb/kio_smb_mount.cpp (4 lines)

Diff 77714

View Options

smb/kio_smb_mount.cpp

Loading...