Differential D27995

[Applet] Fix list item margins
ClosedPublic
Actions

Authored by ngraham on Mar 11 2020, 7:27 PM.

Details

Reviewers
dantti
cblack
ndavis
Group Reviewers
Plasma
Commits
R363:faea0b125911: [Applet] Fix list item margins
Summary

BUG: 360199
BUG: 398681
FIXED-IN: 20.04.0

This is a minimal change needed to fix the aforementioned bugs. Ultimately I would like to
make a re-usable component to implement this "expandable list item" paradigm (which is
also used in the Networks, Bluetooth, Vaults, and Device Notifier applets) so we don't
have to maintain five versions of the code. See T12812.

Test Plan

Before:

After:

Diff Detail

Repository
R363 Print Manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Mar 11 2020, 7:27 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptMar 11 2020, 7:27 PM
ngraham requested review of this revision.Mar 11 2020, 7:27 PM
cblack accepted this revision.Mar 12 2020, 6:51 PM
cblack added a subscriber: cblack.

Code LGTM, and visuals are improved.

This revision is now accepted and ready to land.Mar 12 2020, 6:51 PM
ndavis accepted this revision.Mar 12 2020, 6:51 PM
Closed by commit R363:faea0b125911: [Applet] Fix list item margins (authored by ngraham). · Explain WhyMar 12 2020, 6:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 77517

View Options

plasmoid/package/contents/ui/PrinterItem.qml

Loading...