Fix the tablet mode manager
ClosedPublic

Authored by bshah on Mar 11 2020, 7:17 AM.

Details

Summary

Previously we connected the hasTabletModeSwitchChanged to the
tabletModeAvailableChanged which meant that in startup once libinput
signaled us that we have switch, we would toggle that we now have a
tablet mode.

But, we were connecting this to wrong signal, as a result tablet mode
would become available, but actual tablet switch inputspy was never
getting registered, so tablet mode events were silently ignored.

Test Plan

tested on Dell Inspiron 7000 laptop where tablet mode switch
is available

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bshah created this revision.Mar 11 2020, 7:17 AM
Restricted Application added a project: KWin. · View Herald TranscriptMar 11 2020, 7:17 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
bshah requested review of this revision.Mar 11 2020, 7:17 AM
zzag accepted this revision.Mar 11 2020, 7:25 AM
This revision is now accepted and ready to land.Mar 11 2020, 7:25 AM
This revision was automatically updated to reflect the committed changes.