Fix for NightColor plasmoid active/passive status and its tooltip subtext.
Especially noticeable when the tray icon is set to "Show when relevant".
Tray icon is visible:
Current behavior:
| Mode | Condition | tray icon when Active | tray icon when Inhibited |
|---|---|---|---|
| Timed | daytime | hidden | visible |
| Timed | transitioning period to warm colors | visible | visible |
| Timed | nighttime | visible | visible |
| Timed | transitioning period back to normal | hidden [1] | visible |
| Always on (manual) | - | visible | visible [2] |
[1] this is a bug, icon should be visible here, just like when transitioning to warm colors
[2] why? this duplicates the behavior for "Always shown" tray icon, giving user no choice
New behavior:
| Mode | Condition | tray icon when Active | tray icon when Inhibited |
|---|---|---|---|
| Timed | daytime | hidden | visible |
| Timed | transitioning period to warm colors | visible | visible |
| Timed | nighttime | visible | visible |
| Timed | transitioning period back to normal | VISIBLE [1] | visible |
| Always on (manual) | - | visible | HIDDEN [2] |
UPPERCASE = changed bahavior
[1] fixed
[2] now, with simple tray icon configuration, user can decide if the icon is visible or not here
In all other cases (!monitor.available / !monitor.enabled / !monitor.running) the icon should obviously be hidden.
| Lint Skipped |
| Unit Tests Skipped |
Fix for NightColor plasmoid active/passive status
Could you please describe what's wrong with it right now?
| applets/nightcolor/package/contents/ui/main.qml | ||
|---|---|---|
| 36–38 | We want to keep the applet visible even if Night Color is inhibited so user can quickly uninhibit it. With this patch, the user would have to click the system tray to show hidden icons and after that click the applet icon to uninhibit Night Color. | |
| applets/nightcolor/package/contents/ui/main.qml | ||
|---|---|---|
| 36–38 |
You are right. I have modified the patch to show the icon when inhibited in timed modes. | |
I wanted the icon to hide when Night Color is not affecting color correction (both in timed modes and manual "Always on" mode). Currently the icon is almost always visible.
See updated description.
| applets/nightcolor/package/contents/ui/main.qml | ||
|---|---|---|
| 36–38 | Why only in timed modes? | |
I think this needs a VDG/Usability discussion.
Having the icon show when color correction is active (the status quo) imho makes sense.
I agree.
Could you update the description to be a bit more clear about what exactly has been changed for which cases?
in "Always on" manual mode: when active (not inhibited)
I still don't understand why we should hide the applet. If VDG is okay with such behavior, then feel free to push this change, I won't object or anything.
| applets/nightcolor/package/contents/ui/main.qml | ||
|---|---|---|
| 26 | Please do not use org.kde.colorcorrect in this applet. If you need operation mode constants, please add them to the Monitor class. See D26688 for more details. | |
Actually yeah, I agree with this. I didn't notice that change, sorry. If the user has deliberately turned it always on, then having the tray icon always active by default makes it into a quick on/off toggle, which I think is handy. Sorry for missing this with my earlier review.
Maybe I should explain my motives and probably that would let us (including me) understand the goal better.
I use Night Color only occasionally and I want to be able to turn it on *manually*.
And I like my tray clean.
So I only need this icon when I have it manually engaged (i.e. un-inhibited).
But I perfectly understand the need for Timed modes, which are a great feature.
So they should provide a good user experience as well.
CURRENT STATE:
Currently there is no Manual mode available. You can select "Always on" in configuration, which will engage it every time you log in. This is not good.
And also the "[ ] Activate Night Color" checkbox together with the possibility to inhibit the feature is confusing.
There seem to be two separate ways of controlling this feature.
PROPOSAL:
Maybe we could go with something like this:
We could also polish the naming... current wording used all over this feature are very confusing:
My suggestion (consistent with the proposal above):
CONCLUSION:
So with the Manual mode you have 2 states toggled from the tray icon: "disabled" or "active".
And in Timed modes you can have it "disabled" from the tray icon or otherwise "inactive" (daytime) and "active" (at night).
TRAY ICON:
As for the tray icon visibility (for the states above):
invisible ("Night Color is disabled")
VISIBLE ("Night Color is active") VISIBLE ("Night Color is disabled") invisible ("Night Color is inactive") VISIBLE ("Night Color is active")And of course after setting the tray icon to "Always shown":
VISIBLE ("Night Color is disabled") VISIBLE ("Night Color is active") VISIBLE ("Night Color is disabled") VISIBLE ("Night Color is inactive") VISIBLE ("Night Color is active")I totally missed the D26688 request.
And it proposes some great ideas.
So just to update my mockup accordingly:
As for the tray icon visibility (for the states above):
invisible ("Night Color is disabled. Click to enable.") VISIBLE ("Night Color is active. Click to disable.") VISIBLE ("Night Color is disabled. Click to enable.") invisible ("Night Color is inactive. Activation will begin at...") VISIBLE ("Night Color is active. Colors will return to normal at...")And of course after setting the tray icon to "Always shown":
VISIBLE ("Night Color is disabled. Click to enable.") VISIBLE ("Night Color is active. Click to disable.") VISIBLE ("Night Color is disabled. Click to enable.") VISIBLE ("Night Color is inactive. Activation will begin at...") VISIBLE ("Night Color is active. Colors will return to normal at...")Plus "activating" and "deactivating" states in Timed mode, treated exactly like the "active" one.
It almost sounds like we need a "full manual control" mode where it's expected that the system tray applet or keyboard shortcut will be used to turn it on and off on demand.
Well, isn't this what current inhibition mode does anyway? Both in manual/always-on and in timed modes.
And yes, I have a global shortcut set for this tray icon :) And it somewhat works.
The only annoying issue is that the tray widget for "Night Color Control" gets shown whenever I press this shortcut.
And btw "Night Color Control" widget is completely empty. And it is possible to run into this empty widget - either with the shortcut as mentioned above, or using the vertical bar with icons when the tray icon is hidden.
This widget could probably contain (at least) the information from the tooltip as mocked above or in D26688. Or maybe even some settings (color temperature slidebar?).
You beat me to it; adding a slidebar to manage the color temperate on-the-fly is the next logical evolution here (just like the Display Brightness Control widget, but hopefully with a much greater measure of aesthetic finesse).