Fix valgrind warning in volume and channelMap memcmp
ClosedPublic

Authored by davidedmundson on Sep 16 2016, 9:34 AM.

Details

Summary

Due to a lack of pa_channel_map::&operator==() the code does a memcmp on
the cached m_channelMap to the new version in the update to see if our cache needs
updating.

As our struct starts of uninitialised, vagrlind prints a correct warning
about comparing uninitialised data. However, given our garbage data is
unlikely to match the update, it's not a bug that has a lot of impact.

Test Plan

valgrind plasmashell is quieter

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson retitled this revision from to Fix valgrind warning in volume and channelMap memcmp.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 16 2016, 9:34 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
This revision was automatically updated to reflect the committed changes.