Improve KReportExample main window by combining designer and preview widgets
ClosedPublic

Authored by staniek on Sep 16 2016, 8:29 AM.

Diff Detail

Repository
R14 KReport
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
staniek updated this revision to Diff 6772.Sep 16 2016, 8:29 AM
staniek retitled this revision from to Improve KReportExample main window by combining designer and preview widgets.
staniek updated this object.
staniek edited the test plan for this revision. (Show Details)
staniek added a reviewer: piggz.
staniek added a subscriber: Kexi-Devel-list.
Restricted Application added a project: KReport. · View Herald TranscriptSep 16 2016, 8:29 AM
staniek updated this object.Sep 16 2016, 8:32 AM
staniek updated this revision to Diff 6773.Sep 16 2016, 9:05 AM
  • KReportExample: move the toolbox to the left
  • KReportExample: use more typical kde.org config folder, set names for the dock and toolbars for better config handling
staniek updated this revision to Diff 6786.Sep 16 2016, 9:38 PM
  • Write settings to kde.org/ dir, not org.kde/
staniek updated this object.Sep 16 2016, 9:42 PM
piggz accepted this revision.Sep 18 2016, 7:56 PM
piggz edited edge metadata.
piggz added inline comments.
examples/window.cpp
66

Better to use QCoreApplication::setOrganisationName() etc ?
eg http://doc.qt.io/qt-5/qsettings.html#details
Then just call
QSettings settings;

This revision is now accepted and ready to land.Sep 18 2016, 7:56 PM
staniek updated this revision to Diff 6804.Sep 18 2016, 8:22 PM
staniek edited edge metadata.
  • Set organization domain and use it (and app name) in QSettings
  • Use KReport version as the KReportExample app's version
staniek marked an inline comment as done.Sep 18 2016, 8:23 PM

2 new commits.

examples/window.cpp
66

Right, doing that now. Thanks.

This revision was automatically updated to reflect the committed changes.
staniek marked an inline comment as done.