For very narrow panel item size is too big (item + padding exceed panel size). This adds a check to not exceed panel size.
Before:
After:
ngraham | |
broulik |
Plasma: Workspaces | |
Plasma |
For very narrow panel item size is too big (item + padding exceed panel size). This adds a check to not exceed panel size.
Before:
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
I don't like how icon size and item size (container = icon + padding) are calculated and used... Firstly best icons size is calculated, but then padding are added. This combined size is used as item size (container size):
By happy coincident it is (?) working correctly for all sizes.
There is also a lot of anchoring involved, all items are aligned to left (which looks bad with expander arrow, gap is bigger) etc. But all of this can be fixed in separate patch.
Not sure if it is just me but the vertical alignment looks slightly off
This is just an illusion. I checked and literally counted pixels, centers of icons are aligned (both horizonaly and vertically). "de" icon is visually "heavier" at the bottom, the arrow on the right is heavier on top which makes impresion that these two are not aligned.
After a few days of living with it, I've found that this patch causes the following issue with semi-random tray items getting smaller when a pop-up is opened:
Could you investigate?