[GTK Config] Port all settings to KConfigWatcher
ClosedPublic

Authored by gikari on Mar 9 2020, 8:42 PM.

Details

Summary

Also remove redundant reparse configuration calls and change
the ways of reading some settings accordingly.

Depends on: D27956

Test Plan
  1. Apply D27956
  2. Restart kded5
  3. Apply all the settings possible:
    • Fonts
    • Icons
    • Color Scheme (for dark theme preference setting)
    • Icons on buttons
    • Icons in menus
    • Toolbar style
    • Scrollbar behaviour (what happens if you click on scrollbar)
    • Animations speed (though I haven't touch it in this diff)
    • Decorations button order
  4. Check if all the settings are correctly applied to GTK applications

Diff Detail

Repository
R99 KDE Gtk Configuration Tool
Branch
port-all-to-kconfigwatcher (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23490
Build 23508: arc lint + arc unit
gikari created this revision.Mar 9 2020, 8:42 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 9 2020, 8:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gikari requested review of this revision.Mar 9 2020, 8:42 PM
gikari updated this revision to Diff 77320.Mar 9 2020, 9:00 PM
  • Add forgotten toolbar style

So much less code! Seems to work well for me.

ngraham accepted this revision.Mar 16 2020, 1:50 PM
ngraham edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Mar 16 2020, 1:52 PM
This revision was automatically updated to reflect the committed changes.