Differential D27944

KCM Colors fix apply button always disabled
ClosedPublic
Actions

Authored by crossi on Mar 9 2020, 2:37 PM.

Details

Reviewers
ervin
bport
meven
broulik
Group Reviewers
Plasma
Commits
R119:443b028a1cb3: KCM Colors fix apply button always disabled
R119:4d33b8276e00: KCM Colors fix apply button always disabled
Summary

BUG: 418604

This is similar to D27384

Test Plan

In kdeglobals configuration file :

  • Edit ColorScheme in group General to a non existing value
  • Open the KCM, the default color scheme is selected with a warning message,
  • Select a different scheme, the apply button stay disabled forever.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
crossi created this revision.Mar 9 2020, 2:37 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 9 2020, 2:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
crossi requested review of this revision.Mar 9 2020, 2:37 PM
crossi edited the summary of this revision. (Show Details)Mar 9 2020, 2:41 PM
crossi edited the test plan for this revision. (Show Details)
crossi added a reviewer: broulik.
crossi edited the test plan for this revision. (Show Details)Mar 9 2020, 2:49 PM
ervin accepted this revision.Mar 16 2020, 3:29 PM
This revision is now accepted and ready to land.Mar 16 2020, 3:29 PM
ervin added a comment.Mar 16 2020, 3:30 PM

I marked it accepted, but of course this is assuming David's patch wouldn't make it quickly and we'd need the fix here ASAP.

davidedmundson added a comment.Mar 16 2020, 3:32 PM

Apparently my patch doesn't work, so go ahead.

Though I don't fully understand why my patch isn't enough

Closed by commit R119:4d33b8276e00: KCM Colors fix apply button always disabled (authored by crossi). · Explain WhyMar 19 2020, 9:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcms/colors/colors.cpp (5 lines)

Diff 77980

View Options

kcms/colors/colors.cpp

Loading...