Add twin commands for gj and gk for usage with standard
arrow keys.
BUG: 418486
FIXED-IN: 5.69
Details
Details
- Reviewers
cullmann - Group Reviewers
Kate Frameworks - Commits
- R39:736844969d2b: [VIM Mode] Add g<up> g<down> commands
- Open document with large sentences, that span across multiple visual lines in Kate and use gj and gk commands in normal mode to move inside a line.
- Use g<down> and g<up> commands - the result must be the same, as using gj and gk commands.
- Repeat the same for visual mode.
Diff Detail
Diff Detail
- Repository
- R39 KTextEditor
- Branch
- g-up-g-down-commands (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 23516 Build 23534: arc lint + arc unit
Comment Actions
I like the patch, but please add a unit test before we commit this. See https://github.com/KDE/ktexteditor/tree/master/autotests/src/vimode
Could you add one? :)
Comment Actions
I am not sure where I should add it. Is it supposed to be a new pair of bug418486 .h/.cpp files? Or should the test reside inside keys.cpp in big intimidating 500 line wide MappingTest function?
Comment Actions
I added a unit test, but I do not know why it is failing. Actually I do not know if I've added it correctly at all. Help is very necsasary.
Comment Actions
I will try to take a look as soon as I have time, if nobody else is faster.
Just to confirm: Your newly added test case doesn't pass or some other test case randomly fails?
Comment Actions
I think, one issue is, that <down> and <up> don't work that way in the test framework.
I reformulated the test with \down and \up and moved the asserts to verifies.
This works for me, will push this, please take a look if that is ok for you, too.
Comment Actions
And btw., thanks a lot for taking care!
The vimode for sure has more need for love, if you have time ;=)