[Kicker RootModel] Show separator only when there are entries before it
ClosedPublic
Actions

Authored by broulik on Sep 15 2016, 3:38 PM.

Details

Reviewers

mart
hein

Group Reviewers

Plasma

Commits

Summary

BUG: 368854
FIXED-IN: 5.8.0

Test Plan

Separator shows at the correct position if categories are enabled (tried different configurations) and hides if all are disabled.

Repository

R119 Plasma Desktop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik retitled this revision from to [Kicker RootModel] Show separator only when there are entries before it.

broulik updated this object.

broulik edited the test plan for this revision. (Show Details)

broulik added reviewers: Plasma, hein.

broulik set the repository for this revision to R119 Plasma Desktop.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

hein edited edge metadata.

This revision is now accepted and ready to land.Sep 16 2016, 9:50 AM

looks good to me.
Eike?

I already accepted earlier~

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			applets/kicker/plugin/rootmodel.cpp (14 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	6765			Sep 15 2016, 3:36 PM	★	★
Diff 2	6778	2aa990b	rPLASMADESKTOPc10f722c30e73940399855bce51cbf385b706dee	Sep 16 2016, 12:21 PM	★	★