Differential D27900

smb: fix wsdiscovery unknown device fallback string
ClosedPublic
Actions

Authored by sitter on Mar 6 2020, 3:34 PM.

Details

Reviewers
ngraham
Commits
R320:6557c6b4793d: smb: fix wsdiscovery unknown device fallback string
Summary

wasn't using xi18n so <resource> wasn't parsed as markup but rather used
verbatim. also was missing the argument for %1 so the host address wasn't
included

Test Plan

computer.clear() just prior now results in expected "Unknown device @ "::1"" names for the entries

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Mar 6 2020, 3:34 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptMar 6 2020, 3:34 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Mar 6 2020, 3:34 PM
ngraham accepted this revision.Mar 6 2020, 5:14 PM
This revision is now accepted and ready to land.Mar 6 2020, 5:14 PM
Closed by commit R320:6557c6b4793d: smb: fix wsdiscovery unknown device fallback string (authored by sitter). · Explain WhyMar 6 2020, 5:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msmb/wsdiscoverer.cpp (5 lines)

Diff 77127

View Options

smb/wsdiscoverer.cpp

Loading...