Instead of changing lifespan of kwayland objects we can just call
create() and delete() on it which affects the lifespan of the underlying
resource, but not the kwayland wrapper.
This gets rid of some duplicate syncing.
zzag |
KWin |
Instead of changing lifespan of kwayland objects we can just call
create() and delete() on it which affects the lifespan of the underlying
resource, but not the kwayland wrapper.
This gets rid of some duplicate syncing.
Ran WAYLAND_DEBUG=1
plugged in and removed a monitor
output showed wl_output and xdg_output being handled correctly
Lint Errors | Excuse: asdf |
Severity | Location | Code | Message |
---|---|---|---|
Error | utils.h:123 | Cppcheck | unknownMacro |
Error | utils.h:123 | Cppcheck | unknownMacro |
No Unit Test Coverage |
Buildable 23373 | |
Build 23391: arc lint + arc unit |
This patch looks alright to me, but I don't feel confident about the part where we assume that deletion of the wl_output global won't corrupt the corresponding XdgOutputInterface object. It might bite us in the future.
abstract_wayland_output.cpp | ||
---|---|---|
46–48 | Hmm, we probably don't need a lambda here. &AbstractWaylandOutput::updateDpms should be fine. |