Differential D27886

Demote jump list actions to PossibleMatches
ClosedPublic
Actions

Authored by broulik on Mar 6 2020, 10:36 AM.

Details

Reviewers
davidre
Group Reviewers
Plasma
Commits
R120:18422ededcc9: Demote jump list actions to PossibleMatches
Summary

HelperMatch type was used to identify them in run but this also causes them to score way higher than anything else (except ExactMatch).

BUG: 418529
FIXED-IN: 5.18.3

Test Plan

People complained about the actions (which are valid and useful application-related results!) taking precedence over "real" applications. Instead of removing those actions, improve scoring.

"rectangular" still has "capture recantular region - spectacle" as top result
Installed "Caprine" like in bug report, is now scored higher for "cap" than spectacle's action
"screenshot" now has simple screen recorder instead of steam screenshot gallery as top result

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Mar 6 2020, 10:36 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 6 2020, 10:36 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mar 6 2020, 10:36 AM
davidre accepted this revision.Mar 7 2020, 3:21 PM
This revision is now accepted and ready to land.Mar 7 2020, 3:21 PM
Closed by commit R120:18422ededcc9: Demote jump list actions to PossibleMatches (authored by broulik). · Explain WhyMar 9 2020, 8:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mrunners/services/servicerunner.cpp (14 lines)

Diff 77079

View Options

runners/services/servicerunner.cpp

Loading...