Disable the audio stream indicator for IOTM by default
AbandonedPublic

Authored by ndavis on Mar 5 2020, 3:01 PM.

Details

Reviewers
None
Group Reviewers
VDG
Plasma
Summary

After using it for months, it still gets in the way when used with the Icons-only Task Manager.

Diff Detail

Repository
R119 Plasma Desktop
Branch
disable-audioindicator-iotm (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23329
Build 23347: arc lint + arc unit
ndavis created this revision.Mar 5 2020, 3:01 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 5 2020, 3:01 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ndavis requested review of this revision.Mar 5 2020, 3:01 PM
ndavis edited the summary of this revision. (Show Details)Mar 5 2020, 3:02 PM
cblack added a subscriber: cblack.Mar 5 2020, 3:05 PM

-1, the badge hasn't gotten in my way since the first week or so using it, despite the small size of my panel.

broulik added a subscriber: broulik.Mar 5 2020, 3:06 PM

-1 to removing this feature.

You also need to remove the checkbox on the settings page then.

ngraham added a subscriber: ngraham.Mar 5 2020, 3:06 PM

I can't say that it's gotten in the way for me either, with my thick panel. It does overlap the badge icon though which is a bit annoying.

Also yes, if you want to remove this from the IOTM, you need to hide the setting on the IOTM's config page too.

ndavis updated this revision to Diff 77043.Mar 5 2020, 3:13 PM
  • Hide audio indicator setting for IOTM
ndavis added a comment.Mar 5 2020, 3:14 PM

Do we really want a feature that new users have to learn to dodge?

gvgeo added a subscriber: gvgeo.Mar 5 2020, 3:21 PM

Disable the mute function then. And maybe add as an option.

ndavis updated this revision to Diff 77045.Mar 5 2020, 3:35 PM
  • Use an option instead

Title needs updating to reflect the current state of the patch, if you'd still like to propose that we do this. I'm still not sure I understand the point. The indicator is already disable-able for both the IOTM and TTM. What value is being gained here?

ndavis retitled this revision from Disable the audio stream indicator for IOTM to Disable the audio stream indicator for IOTM by default.Mar 16 2020, 11:51 PM

Title needs updating to reflect the current state of the patch, if you'd still like to propose that we do this. I'm still not sure I understand the point. The indicator is already disable-able for both the IOTM and TTM. What value is being gained here?

it's an annoyance enabled by default. I suppose the fact it can be clicked on could be made optional, but do we really want to add more options?

I won't block this, but personally I don't find the indicator to be a problem with my IOTM. When I click on an icon, I'm almost always clicking on a pixel adjacent to the screen edge, which is on the other side of where the audio indicator is drawn, so it never gets in the way functionally.

ndavis abandoned this revision.Tue, May 19, 7:51 PM

Abandoning this since nobody wanted it.