[applets/systemtray] Right align popup heading when in RTL mode
AbandonedPublic

Authored by filipf on Mar 5 2020, 2:21 PM.

Details

Reviewers
None
Group Reviewers
Plasma
VDG
Summary

In RTL modes headings should be on the right, not on the left as is currently the case.

Filling the layout's width is not enough so we'll set a left aligned horizontal policy for the headings, which gets mirrored into a right aligned one in RTL.

Test Plan

plasmashell --reverse --replace

Before:

After:

Diff Detail

Repository
R120 Plasma Workspace
Branch
heading-on-the-right (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23317
Build 23335: arc lint + arc unit
filipf created this revision.Mar 5 2020, 2:21 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 5 2020, 2:21 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Mar 5 2020, 2:21 PM
filipf edited the test plan for this revision. (Show Details)Mar 5 2020, 2:22 PM
filipf added reviewers: Plasma, VDG.
ngraham added a subscriber: ngraham.Mar 5 2020, 3:05 PM

Feels like this should be set by default in the Heading item, or else we'll be doing this everywhere, no?

filipf added a comment.Mar 5 2020, 3:10 PM

Feels like this should be set by default in the Heading item, or else we'll be doing this everywhere, no?

Sounds like a better solution. I'm not sure if it would interfere with some weird use case though?

I doubt it. left-alignment is already the effective default anyway, so I'm actually surprised that explicitly setting it here makes RTL work. This hints at a deeper bug somewhere, unfortunately.

gvgeo added a subscriber: gvgeo.Mar 5 2020, 4:46 PM

It seems that QQC2 as long a horizontal value is set, will flip it around. Otherwise will use the default direction left.
Agree, looks like a bug. Kirigami and frameworks are the places where this should be set. Already have corrected the other patch.

filipf abandoned this revision.Mar 5 2020, 4:49 PM