Differential D27857

Port some usage of QRegExp to QRegularExpression
ClosedPublic
Actions

Authored by ahmadsamir on Mar 5 2020, 7:26 AM.

Tags

Subscribers

Details

Reviewers

davidedmundson
apol
broulik

Group Reviewers

Commits

R120:f444ebe595a2: Port some usage of QRegExp to QRegularExpression

Test Plan

make && ctest

Diff Detail

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ahmadsamir created this revision.Mar 5 2020, 7:26 AM

Restricted Application added a project: Plasma. · View Herald TranscriptMar 5 2020, 7:26 AM

ahmadsamir requested review of this revision.Mar 5 2020, 7:26 AM

Harbormaster completed remote builds in B23285: Diff 76991.Mar 5 2020, 7:26 AM

ahmadsamir added reviewers: davidedmundson, apol, broulik.Mar 15 2020, 9:15 PM

Ping.

+1 overall

dataengines/devicenotifications/ksolidnotify.cpp
131	it could make sense to use splitRef here, unsure where this is used.
ksmserver/server.cpp
671	Why the changes from [0-9] to \d?

Address comments

Harbormaster completed remote builds in B23859: Diff 77898.Mar 18 2020, 11:37 AM

ahmadsamir added inline comments.Mar 18 2020, 12:18 PM

ksmserver/server.cpp
671	Less cluttered; but maybe not as readable. I'll revert it.

Verbatim

Harbormaster completed remote builds in B23863: Diff 77905.Mar 18 2020, 12:19 PM

ahmadsamir edited the summary of this revision. (Show Details)Mar 18 2020, 12:20 PM

Verbatim

Harbormaster completed remote builds in B23864: Diff 77906.Mar 18 2020, 12:20 PM

apol accepted this revision.Mar 18 2020, 3:53 PM

apol added inline comments.

runners/calculator/calculatorrunner.cpp
199–200	If you could look into de-duplicating these QRegularExpressions in a separate patch, that would be awesome.

This revision is now accepted and ready to land.Mar 18 2020, 3:53 PM

Closed by commit R120:f444ebe595a2: Port some usage of QRegExp to QRegularExpression (authored by ahmadsamir). · Explain WhyMar 18 2020, 4:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			applets/digital-clock/plugin/clipboardmenu.cpp (7 lines)
M			dataengines/devicenotifications/ksolidnotify.cpp (5 lines)
M			dataengines/weather/ions/bbcukmet/ion_bbcukmet.cpp (14 lines)
M			ksmserver/server.cpp (8 lines)
M			libkworkspace/kdisplaymanager.cpp (1 line)
M			libkworkspace/kworkspace.cpp (2 lines)
M			runners/calculator/calculatorrunner.cpp (16 lines)
M			shell/panelview.cpp (4 lines)

Diff 77932

applets/digital-clock/plugin/clipboardmenu.cpp

Loading...

dataengines/devicenotifications/ksolidnotify.cpp

Loading...

dataengines/weather/ions/bbcukmet/ion_bbcukmet.cpp

Loading...

ksmserver/server.cpp

Loading...

libkworkspace/kdisplaymanager.cpp

Loading...

libkworkspace/kworkspace.cpp

Loading...

runners/calculator/calculatorrunner.cpp

Loading...

shell/panelview.cpp

Loading...