Differential D27824

Use consistent highlight
ClosedPublic
Actions

Authored by niccolove on Mar 4 2020, 9:40 AM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
VDG
Commits
R97:24f2bd58bb5a: Use consistent highlight
Summary

This uses the PlasmaComponents.Highlight feature to be consistent with other lists

Diff Detail

Repository
R97 Bluedevil
Branch
highlight (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23294
Build 23312: arc lint + arc unit
niccolove created this revision.Mar 4 2020, 9:40 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 4 2020, 9:40 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
niccolove requested review of this revision.Mar 4 2020, 9:40 AM
ngraham accepted this revision.Mar 4 2020, 3:41 PM
ngraham added a subscriber: ngraham.

Need to adjust the button's right margin in DeviceItem.qml as well:

Could be done in another patch.

This revision is now accepted and ready to land.Mar 4 2020, 3:41 PM
niccolove updated this revision to Diff 77002.Mar 5 2020, 10:21 AM

Remove previous highlight

niccolove added a comment.Mar 5 2020, 10:27 AM

Seems correct to me - rather, the nm button is way too on the right. I could make that one consistent instead.

Closed by commit R97:24f2bd58bb5a: Use consistent highlight (authored by niccolove). · Explain WhyMar 8 2020, 2:54 PM
This revision was automatically updated to reflect the committed changes.
niccolove added a comment.Mar 8 2020, 4:13 PM

Wait, I think I understood the reason

Revision Contents
Changeset List

Diff 77002

View Options

src/applet/package/contents/ui/DeviceItem.qml

Loading...
View Options

src/applet/package/contents/ui/FullRepresentation.qml

Loading...