Use consistent highlight
ClosedPublic

Authored by niccolove on Wed, Mar 4, 9:40 AM.

Details

Summary

This uses the PlasmaComponents.Highlight feature to be consistent with other lists

Diff Detail

Repository
R97 Bluedevil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
niccolove created this revision.Wed, Mar 4, 9:40 AM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, Mar 4, 9:40 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
niccolove requested review of this revision.Wed, Mar 4, 9:40 AM
ngraham accepted this revision.Wed, Mar 4, 3:41 PM
ngraham added a subscriber: ngraham.

Need to adjust the button's right margin in DeviceItem.qml as well:

Could be done in another patch.

This revision is now accepted and ready to land.Wed, Mar 4, 3:41 PM
niccolove updated this revision to Diff 77002.Thu, Mar 5, 10:21 AM

Remove previous highlight

Seems correct to me - rather, the nm button is way too on the right. I could make that one consistent instead.

This revision was automatically updated to reflect the committed changes.

Wait, I think I understood the reason