Differential D27821

Introduce AbstractClient::destroyClient()
ClosedPublic
Actions

Authored by zzag on Mar 4 2020, 8:21 AM.

Details

Reviewers

davidedmundson

Group Reviewers

KWin

Commits

R108:861883895d20: Introduce AbstractClient::destroyClient()

Summary

The new method provides a generic way for destructing clients. Notice
that we can't just delete clients because we may need to discard
temporary window rules, which is usually done in destroyClient().

Test Plan

Compiles.

Diff Detail

Repository

R108 KWin

Lint

Lint Skipped

Excuse: foobar

Unit

No Unit Test Coverage

Build Status

Buildable 23226
Build 23244: arc lint + arc unit

zzag created this revision.Mar 4 2020, 8:21 AM

Restricted Application added a project: KWin. · View Herald TranscriptMar 4 2020, 8:21 AM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.Mar 4 2020, 8:21 AM

Harbormaster completed remote builds in B23224: Diff 76902.Mar 4 2020, 8:21 AM

zzag added a dependent revision: D27822: Introduce AbstractClient::createDecoration().Mar 4 2020, 8:22 AM

Don't move code around.

Harbormaster completed remote builds in B23226: Diff 76904.Mar 4 2020, 8:25 AM

davidedmundson accepted this revision.Mar 4 2020, 10:02 AM

This revision is now accepted and ready to land.Mar 4 2020, 10:02 AM

Closed by commit R108:861883895d20: Introduce AbstractClient::destroyClient() (authored by zzag). · Explain WhyMar 4 2020, 12:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			abstract_client.h (1 line)
M			internal_client.h (2 lines)
M			workspace.cpp (6 lines)
M			x11client.h (2 lines)
M			xdgshellclient.h (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	76902	be759b7		Mar 4 2020, 8:21 AM	★	★
Diff 2	76904	be759b7	Don't move code around.	Mar 4 2020, 8:25 AM	★	★
Diff 3	76931	be759b7	R108:861883895d2028c68bc5f1274f86af63dc6d1a7f	Mar 4 2020, 12:40 PM	★	★