Differential D27810

Correctly disable UDS_ACCESS being set
ClosedPublic
Actions

Authored by davidedmundson on Mar 3 2020, 6:17 PM.

Details

Reviewers
sitter
feverfew
Commits
R320:01e442c75140: Correctly disable UDS_ACCESS being set
R320:c00f4706146a: Merge branch 'release/19.12'
Summary

718abcb69b78385123dd7a05a66a656af772d581 tries to disable UDS_ACCESS
being set. See the long comment introduced.

It did this by setting the value to -1 which doesn't achieve that
result.

-1 is a perfectly valid value that gets send to the client.

Having it set breaks anyone calling udsEntry.numberValue(UDS_ACCESS,
aLegitimateDefault) getting their default. Something used by kio-fuse.

Test Plan

Used kio-fuse
Opened a samba file in mplayer
It opened

Opened a text editor in kate (using regular kio)

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Mar 3 2020, 6:17 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptMar 3 2020, 6:17 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Mar 3 2020, 6:17 PM
davidedmundson edited the test plan for this revision. (Show Details)Mar 3 2020, 6:21 PM
sitter accepted this revision.Mar 3 2020, 6:44 PM

I am pretty sure I picked that up somewhere, might be worth asking lxr for possible other places we set ACCESS to -1

This revision is now accepted and ready to land.Mar 3 2020, 6:44 PM
Closed by commit R320:01e442c75140: Correctly disable UDS_ACCESS being set (authored by davidedmundson). · Explain WhyMar 3 2020, 7:37 PM
This revision was automatically updated to reflect the committed changes.
feverfew added a comment.Mar 3 2020, 8:26 PM
In D27810#621427, @sitter wrote:

I am pretty sure I picked that up somewhere, might be worth asking lxr for possible other places we set ACCESS to -1

grep through kio/kio-extras doesn't reveal this being a pattern.

sitter added a comment.Mar 4 2020, 10:13 AM

Yeah, can't find anything either, I may be thinking of the numberValue query in CopyJob, so entirely unrelated.

Revision Contents
Changeset List

PathPackages
Msmb/kio_smb_browse.cpp (2 lines)

Diff 76879

View Options

smb/kio_smb_browse.cpp

Loading...