Fix symlink problem because of using relative path instead of full path
Needs RevisionPublic

Authored by usta on Mar 2 2020, 9:40 PM.

Details

Summary

generate script was trying to read the source of symlinked files base but it was used as a relative path which causes problems for broken new symlinks.
This fix is getting the full path of symlink so newly created files use correct path instead of a broken symlink also this fixes autotests (obvious because that problem will be solved :) )

Diff Detail

Repository
R266 Breeze Icons
Lint
Lint Skipped
Unit
Unit Tests Skipped
usta created this revision.Mar 2 2020, 9:40 PM
Restricted Application added a subscriber: kde-frameworks-devel. ยท View Herald TranscriptMar 2 2020, 9:40 PM
usta requested review of this revision.Mar 2 2020, 9:40 PM
ndavis requested changes to this revision.Mar 3 2020, 4:36 AM

Relative links are actually necessary. Otherwise, they won't work when the source repository isn't present.

This revision now requires changes to proceed.Mar 3 2020, 4:36 AM
ndavis added a comment.Mar 3 2020, 4:40 AM

Example:

I renamed the original breeze-icons repo to breeze-icons2 and the symlinks broke because they were pointing to the source folder instead of the installation folder.

ngraham requested changes to this revision.Mar 4 2020, 6:07 PM

Yes, the generation of relative symlinks is intentional and necessary.