Differential D27789

[autotests] Fix failing KeyboardLayoutTest::testNumLock()
ClosedPublic
Actions

Authored by zzag on Mar 2 2020, 4:40 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:5d580b9fb2ee: [autotests] Fix failing KeyboardLayoutTest::testNumLock()
Summary

Since Qt::KeypadModifier is set only for keypad keys and not the NumLock
key, we need to press at least one keypad key to determine whether
numlock is actually on. On the other hand, we know that when numlock is
on, the corresponding LED is also on. So we could check the LED rather
than press two keys.

Test Plan

testKeyboardLayout passes.

Diff Detail

Repository
R108 KWin
Branch
check-led-status-in-test-num-lock
Lint
Lint SkippedExcuse: foo
Unit
No Unit Test Coverage
Build Status
Buildable 23153
Build 23171: arc lint + arc unit
zzag created this revision.Mar 2 2020, 4:40 PM
Restricted Application added a project: KWin. · View Herald TranscriptMar 2 2020, 4:40 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Mar 2 2020, 4:40 PM
davidedmundson accepted this revision.Mar 2 2020, 4:50 PM
This revision is now accepted and ready to land.Mar 2 2020, 4:50 PM
Closed by commit R108:5d580b9fb2ee: [autotests] Fix failing KeyboardLayoutTest::testNumLock() (authored by zzag). · Explain WhyMar 2 2020, 5:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 76785

View Options

autotests/integration/keyboard_layout_test.cpp

Loading...