UserInfoDialog.qml an Item with a Rectangle in it, could you use a Window?

https://doc.qt.io/qt-5/qml-qtquick-window-window.html

In D27783#630734, @ngraham wrote:

UserInfoDialog.qml an Item with a Rectangle in it, could you use a Window?

https://doc.qt.io/qt-5/qml-qtquick-window-window.html

I don't think that would be correct use, in my case it's a QDialog, with a QML content, while Window (qml one) would be used if I don't use QDialog.

How can I test this?

In D27783#632600, @ngraham wrote:

How can I test this?

I don't know if there is any application using this, but I test it with my testing application in libportal.

You can get it here: https://github.com/grulja/libportal/tree/qt-wrapper

You need to clone the repo, go to "qt-wrapper" branch and build it, then in portal-test-qt folder there will be a simple Qt application.

Ok. When trying to compile I get the following:

In file included from ../libportal/portal-qt5.h:20,
                 from libportal-qt/a370903@@LibPortalQt@sha/../../../libportal-qt/portal_p.h:24,
                 from libportal-qt/a370903@@LibPortalQt@sha/../../../libportal-qt/parent_p.h:21,
                 from libportal-qt/a370903@@LibPortalQt@sha/moc_parent_p.cpp:10:
../libportal/portal.h:20:10: fatal error: libportal/portal-enums.h: No such file or directory
   20 | #include <libportal/portal-enums.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~

More generally, what does this thing do? What's it for?

In D27783#632900, @ngraham wrote:

Ok. When trying to compile I get the following:

In file included from ../libportal/portal-qt5.h:20,
                 from libportal-qt/a370903@@LibPortalQt@sha/../../../libportal-qt/portal_p.h:24,
                 from libportal-qt/a370903@@LibPortalQt@sha/../../../libportal-qt/parent_p.h:21,
                 from libportal-qt/a370903@@LibPortalQt@sha/moc_parent_p.cpp:10:
../libportal/portal.h:20:10: fatal error: libportal/portal-enums.h: No such file or directory
   20 | #include <libportal/portal-enums.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~

More generally, what does this thing do? What's it for?

Do you mean libportal or this portal? Libportal is a library for applications to use portal support without need to do all the calls themself over DBus and they can use a much friendly API.

This portal allows application to get user name, user real name and user avatar. Normally applications outside sandbox have DBus access so they can query libaccount themself, but given sandbox restrictions, you have to go through a portal and that's why we show a dialog, asking the user whether he wants to provide information to the sadboxed application. The dialog will always look the same, it will just have different user name, real name and picture and reason why the application needs the access.

In D27783#632940, @ngraham wrote:

Ah, thanks. LGTM. Would you be okay with me submitting a patch to alter/polish the UI after it lands?

Absolutely!