expose IncludeUsage to QML api
ClosedPublic

Authored by mart on Mar 2 2020, 1:41 PM.

Details

Summary

RecentUsageModel can list all aps and docs,
only aps or only docs. make possible to control that from QML

Test Plan

the api works, all existing code has the same behavior as before

Diff Detail

Repository
R120 Plasma Workspace
Branch
phab/exposeusage
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23141
Build 23159: arc lint + arc unit
mart created this revision.Mar 2 2020, 1:41 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 2 2020, 1:41 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Mar 2 2020, 1:41 PM

generally makes sense

applets/kicker/plugin/recentusagemodel.cpp
150

we have QQmlParserStatus in this class, we probably want to use it.

applets/kicker/plugin/recentusagemodel.h
69

Can we pick something a bit more specific.

Everything fits under "usage"

mart added inline comments.Mar 2 2020, 2:18 PM
applets/kicker/plugin/recentusagemodel.cpp
150

refresh() implementation already has a check on m_completed (which is set on componentCompleted)

mart updated this revision to Diff 76774.Mar 2 2020, 2:58 PM
  • rename property to shownItems
davidedmundson accepted this revision.Mar 3 2020, 10:30 AM
This revision is now accepted and ready to land.Mar 3 2020, 10:30 AM
This revision was automatically updated to reflect the committed changes.