Expose the banner sourceSize
AbandonedPublic

Authored by apol on Sep 14 2016, 3:57 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Summary

This way one can put svg images

Test Plan

Works with Discover using it and kirigamigallery as is

Diff Detail

Repository
R169 Kirigami
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol updated this revision to Diff 6743.Sep 14 2016, 3:57 PM
apol retitled this revision from to Expose the banner sourceSize.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami. · View Herald TranscriptSep 14 2016, 3:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Sep 15 2016, 10:08 AM
mart edited edge metadata.

patch in general makes sense

but are you sure svg doesn't export a soucesize? (svgs do have a size in pixels in their root layer and qtsvg supports it)

This revision is now accepted and ready to land.Sep 15 2016, 10:08 AM
apol added a comment.Sep 15 2016, 10:53 AM
In D2778#51900, @mart wrote:

patch in general makes sense

but are you sure svg doesn't export a soucesize? (svgs do have a size in pixels in their root layer and qtsvg supports it)

Of course it does, but it's a size, here we're not interested in giving it a size, we just should make sure it fits the banner.
We could set a 5000x3000 size, but then we'd be rendering it too big then scaling it down.

If you ask me, we should just make Kirigami enforce the look of the banner (despite the developer adding a strictly vertical image), then this property wouldn't be required.

mart added a comment.Sep 26 2016, 9:15 AM

what's the status of that?

apol abandoned this revision.Sep 26 2016, 10:36 AM

I don't like the patch, I'll find a way to work around it.